Consider AAA flags when adding input data to WMBS #12212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am still unsure whether this should at some point be merged or not, as there might be undesired behaviors for some specific scenarios, for instance:
In any case, I want to apply this to submit10, as being discussed here: #12210 |
|
Jenkins results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11501
Status
not-tested
Description
To avoid workqueue elements failing to be acquired from LQE to WMBS in WorkQueueManager, fallback data location to the output of
possibleSites()from https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/WorkQueue/DataStructs/WorkQueueElement.py#L18 whenever a Rucio rule is not fully satisfied (and AAA has been enabled for the workflow).Without this change, LQE will keep failing to be acquired by WMBS until data converges to the destination (likely after someone identifies it, discuss with the DM team and actions are taken...).
This development may have one potential drawback though, in case data is not available anywhere on Disk, jobs will likely fail to read the input data. Hopefully data will converge before job retries are exhausted. Otherwise, ACDC documents will be created reporting data location as the expected location for that file (usually a logical OR used of RSEs).
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None